github-release-cli: Rename 'file' parameter to 'data'#16
Closed
theimpulson wants to merge 2 commits intocheton:masterfrom
theimpulson:master
Closed
github-release-cli: Rename 'file' parameter to 'data'#16theimpulson wants to merge 2 commits intocheton:masterfrom theimpulson:master
theimpulson wants to merge 2 commits intocheton:masterfrom
theimpulson:master
Conversation
Fixes the following warning:
{ Deprecation: [@octokit/rest] "file" parameter is deprecated for ".repos.uploadReleaseAsset()". Use "data" instead
at Object.keys.forEach.key (/usr/local/lib/node_modules/github-release-cli/node_modules/@octokit/plugin-rest-endpoint-methods/dist-node/index.js:13145:26)
at Array.forEach (<anonymous>)
at Object.patchedMethod [as uploadReleaseAsset] (/usr/local/lib/node_modules/github-release-cli/node_modules/@octokit/plugin-rest-endpoint-methods/dist-node/index.js:13142:26)
at _callee2$ (/usr/local/lib/node_modules/github-release-cli/lib/index.js:412:50)
at tryCatch (/usr/local/lib/node_modules/github-release-cli/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/usr/local/lib/node_modules/github-release-cli/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/usr/local/lib/node_modules/github-release-cli/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/usr/local/lib/node_modules/github-release-cli/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /usr/local/lib/node_modules/github-release-cli/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
at process._tickCallback (internal/process/next_tick.js:68:7) name: 'Deprecation' }
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Fixes the following warning:
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
This is an octokit issue and has been fixed in later versions
Ref: actions/toolkit#333
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
cheton
added a commit
that referenced
this pull request
Sep 20, 2020
Owner
|
fixed in #22 |
cheton
added a commit
that referenced
this pull request
Sep 20, 2020
* chore: bump to v2 * docs: update README.md * chore: add @babel/core * chore: add @babel/register * chore: rename babel-register to @babel/register * chore: rename 'file' parameter to 'data' (#16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #15
Signed-off-by: Aayush Gupta aayushgupta219@gmail.com